DATACOUCH-1066 - N1qlExpression as QueryCriteria key. #1081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: mikereiche <[email protected]>
Co-authored-by: mikereiche <[email protected]>
Co-authored-by: mikereiche <[email protected]>
Co-authored-by: mikereiche <[email protected]>
…deleteById(Iterable<ID> ids). Original pull request: #279.
Reorder methods. Remove superfluous final keyword. Reformat pom. Fix dependency to Spring Data Commons. Original pull request: #279.
Co-authored-by: mikereiche <[email protected]>
…enly changing. (#290)
…and version properties. Related tickets: - #1072
…r() but receiving a String key. Related tickets: - #1072
This is a merge of mmonti's changeset into master. The changeset was made on top of 4.1.x instead of master so it has a little catching up to do. Merge branch 'gh-1066-n1qlexpression-as-querycriteria-key' of github.com:mmonti/spring-data-couchbase into datacouch_1066_1072_mmonti_n1ql_query_creator_expression Original pull request #1076
|
Hi @mikereiche, I just saw the comment on this PR:
Should I try to create the same changes on top of master? Let me know, I can give it a try... |
|
Hi @mmonti - Thanks for your branch. I adjusted it for master and committed to master and then cherry-picked it for 4.1.x after. The 4.1.7 release should go out tomorrow with your changes (it was supposed to go out today, that's why I rushed to get your change in). The only thing that didn't work out is that it doesn't show it was your branch. Sorry. |
|
Ah! got it! Awesome!.. no worries about the branch. |
mikereiche
deleted the
datacouch_1066_1072_mmonti_n1ql_query_creator_expression
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a merge of mmonti's changeset into master. The changeset was made
on top of 4.1.x instead of master so it has a little catching up to do.
Merge branch 'gh-1066-n1qlexpression-as-querycriteria-key' of github.com:mmonti/spring-data-couchbase into datacouch_1066_1072_mmonti_n1ql_query_creator_expression
Original pull request #1076